[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected |
|
Date: |
Thu, 29 Apr 2021 14:57:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/28/21 9:12 PM, Philippe Mathieu-Daudé wrote:
> On 4/28/21 9:04 PM, Alex Bennée wrote:
>>
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> On 4/28/21 7:06 PM, Alex Bennée wrote:
>>>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>>>
>>>>> Alex, Richard, do you mind reviewing this one please?
>>>>
>>>> Isn't it already merged (with my r-b tag no less ;-)
>>>>
>>>> f77147cd4de8c726f89b2702f7a9d0c9711d8875
>>>
>>> See ...
>>>
>>>> Author: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> AuthorDate: Fri Jan 22 21:44:31 2021 +0100
>>>> Commit: Paolo Bonzini <pbonzini@redhat.com>
>>>> CommitDate: Mon Feb 8 14:43:55 2021 +0100
>>>>
>>>>>
>>>>> On 4/15/21 6:33 PM, Philippe Mathieu-Daudé wrote:
>>>>>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>>>
>>>>>> The previous attempt (commit f77147cd4de) doesn't work as
>>>
>>> ... ^ this comment :(
>>
>> Ahh - my tooling was confused having searched by the subject title ;-)
>
> Oh I see, I'll rename as:
> "tests/meson: Only build softfloat objects if TCG is selected (again)".
BTW you indeed reviewed/tested v1 of this patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg793900.html
but after addressing Paolo's comments I preferred to remove your tags.
- Re: [PATCH v4 10/12] qtest/qmp-cmd-test: Make test build-independent from accelerator, (continued)
[PATCH v4 11/12] tests/qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore, Philippe Mathieu-Daudé, 2021/04/15
[PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected, Philippe Mathieu-Daudé, 2021/04/15
Re: [PATCH v4 12/12] tests/meson: Only build softfloat objects if TCG is selected, Alex Bennée, 2021/04/30