[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/30] target/arm: Rename TBFLAG_A32, SCTLR_B
From: |
Peter Maydell |
Subject: |
Re: [PATCH v4 02/30] target/arm: Rename TBFLAG_A32, SCTLR_B |
Date: |
Mon, 19 Apr 2021 18:03:59 +0100 |
On Fri, 16 Apr 2021 at 20:00, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> We're about to rearrange the macro expansion surrounding tbflags,
> and this field name will be expanded using the bit definition of
> the same name, resulting in a token pasting error.
>
> So SCTLR_B -> SCTLR__B in the 3 uses, and document it.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
The new name is kinda ugly.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v4 for-6.1 00/39] target/arm: enforce alignment, Richard Henderson, 2021/04/16
- [PATCH v4 01/30] target/arm: Fix decode of align in VLDST_single, Richard Henderson, 2021/04/16
- [PATCH v4 02/30] target/arm: Rename TBFLAG_A32, SCTLR_B, Richard Henderson, 2021/04/16
- Re: [PATCH v4 02/30] target/arm: Rename TBFLAG_A32, SCTLR_B,
Peter Maydell <=
- [PATCH v4 05/30] target/arm: Introduce CPUARMTBFlags, Richard Henderson, 2021/04/16
- [PATCH v4 03/30] target/arm: Rename TBFLAG_ANY, PSTATE_SS, Richard Henderson, 2021/04/16
- [PATCH v4 04/30] target/arm: Add wrapper macros for accessing tbflags, Richard Henderson, 2021/04/16
- [PATCH v4 08/30] target/arm: Move TBFLAG_ANY bits to the bottom, Richard Henderson, 2021/04/16
- [PATCH v4 06/30] target/arm: Move mode specific TB flags to tb->cs_base, Richard Henderson, 2021/04/16