Re: [PATCH v1 2/8] hw/intc: GICv3 ITS register definitions added

[Richard Henderson]

On 3/31/21 9:48 AM, shashi.mallela@linaro.org wrote:
> > > +        if (!(s->ctlr & GITS_CTLR_ENABLED)) {
> > > +            s->cbaser = value;
> > > +            if (!extract_cmdq_params(s)) {
> > > +                qemu_log_mask(LOG_GUEST_ERROR,
> > > +                       "%s: error extracting GITS_CBASER
> > > parameters "
> > > +                       TARGET_FMT_plx "\n", __func__, offset);
> >
> > So are these all LOG_UNIMP or are they a programming failure on our
> > part?
> they are not LOG_UNIMP but error indications during processing which
> could be due to invalid parameters passed from the driver

Then we should re-word the message so that it does not read as if it is a qemu 
problem, but a guest problem.

It is difficult to do this with the code structure you've written, but you 
could use an Error** parameter (include/qabi/error.h) to extract_cmdq_params so 
that you can diagnose exactly what is wrong.


r~