Re: [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine

[no-reply]

Patchew URL: 20210324070955.125941-1-joel@jms.id.au/">https://patchew.org/QEMU/20210324070955.125941-1-joel@jms.id.au/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210324070955.125941-1-joel@jms.id.au
Subject: [PATCH v4 0/3] hw/misc: Model ASPEED hash and crypto engine

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210324070955.125941-1-joel@jms.id.au -> 
patchew/20210324070955.125941-1-joel@jms.id.au
Switched to a new branch 'test'
5ebc2c5 tests/qtest: Add test for Aspeed HACE
6fc1946 aspeed: Integrate HACE
fa3bbae hw: Model ASPEED's Hash and Crypto Engine

=== OUTPUT BEGIN ===
1/3 Checking commit fa3bbae71dd5 (hw: Model ASPEED's Hash and Crypto Engine)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

WARNING: line over 80 characters
#95: FILE: hw/misc/aspeed_hace.c:69:
+    { HASH_ALGO_SHA512_SERIES | HASH_ALGO_SHA512_SHA512, 
QCRYPTO_HASH_ALG_SHA512 },

WARNING: line over 80 characters
#96: FILE: hw/misc/aspeed_hace.c:70:
+    { HASH_ALGO_SHA512_SERIES | HASH_ALGO_SHA512_SHA384, 
QCRYPTO_HASH_ALG_SHA384 },

WARNING: line over 80 characters
#97: FILE: hw/misc/aspeed_hace.c:71:
+    { HASH_ALGO_SHA512_SERIES | HASH_ALGO_SHA512_SHA256, 
QCRYPTO_HASH_ALG_SHA256 },

ERROR: braces {} are necessary for all arms of this statement
#105: FILE: hw/misc/aspeed_hace.c:79:
+        if (mask == hash_algo_map[i].mask)
[...]

WARNING: line over 80 characters
#212: FILE: hw/misc/aspeed_hace.c:186:
+                          "%s: HMAC engine command mode %"PRIx64" not 
implemented",

total: 1 errors, 5 warnings, 408 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit 6fc194601e1b (aspeed: Integrate HACE)
3/3 Checking commit 5ebc2c5642da (tests/qtest: Add test for Aspeed HACE)
WARNING: line over 80 characters
#130: FILE: tests/qtest/aspeed_hace-test.c:91:
+    write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, 
HACE_ALGO_MD5);

WARNING: line over 80 characters
#161: FILE: tests/qtest/aspeed_hace-test.c:122:
+    write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, 
HACE_ALGO_SHA256);

WARNING: line over 80 characters
#192: FILE: tests/qtest/aspeed_hace-test.c:153:
+    write_regs(s, base, src_addr, sizeof(test_vector), digest_addr, 
HACE_ALGO_SHA512);

WARNING: line over 80 characters
#253: FILE: tests/qtest/aspeed_hace-test.c:214:
+    g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DIGEST), ==, 
expected->dest);

WARNING: line over 80 characters
#256: FILE: tests/qtest/aspeed_hace-test.c:217:
+    g_assert_cmphex(qtest_readl(s, base + HACE_HASH_DATA_LEN), ==, 
expected->len);

total: 0 errors, 5 warnings, 335 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210324070955.125941-1-joel@jms.id.au/testing.checkpatch/?type=message">http://patchew.org/logs/20210324070955.125941-1-joel@jms.id.au/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com