[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in Devic
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[PATCH v2 3/3] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() |
|
Date: |
Tue, 23 Mar 2021 17:14:43 +0100 |
When QDev objects have their DeviceReset handler set, they
shouldn't worry about calling it at realization stage (it
is handled by hw/core/qdev.c::device_set_realized).
Remove the pointless/confusing bcm2835_fb_reset() call.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/display/bcm2835_fb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c
index a9c2e57d1c6..d7a44771c44 100644
--- a/hw/display/bcm2835_fb.c
+++ b/hw/display/bcm2835_fb.c
@@ -421,8 +421,6 @@ static void bcm2835_fb_realize(DeviceState *dev, Error
**errp)
s->dma_mr = MEMORY_REGION(obj);
address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_FB "-memory");
- bcm2835_fb_reset(dev);
-
s->con = graphic_console_init(dev, 0, &vgafb_ops, s);
qemu_console_resize(s->con, s->config.xres, s->config.yres);
}
--
2.26.2