Re: [PATCH for-6.0 v2 4/5] hw/core/loader: Add new function rom_ptr_for_as()

[Richard Henderson]

On 3/18/21 1:02 PM, Peter Maydell wrote:
> > > +     * Note that we do not check @as against the 'as' member in the
> > > +     * 'struct Rom' returned by rom_ptr(). The Rom::as is the
> > > +     * AddressSpace which the rom blob should be written to...
...
> > Should you really have this special case?  Nowhere is this going to verify that
> > @addr is in @as.
>
> It's the "happens almost all the time" case. Nothing verifies
> that @addr is in @as anyway -- see the "Note that" part of the
> comment above.

The comment explains why we don't examine Rom::as.
But we do check @addr vs @as via @as -> @fv -> flatview_translate.


r~