Re: [PATCH v2] tests/acceptance: Add bFLT loader linux-user test

[Willian Rampazzo]

Hi Thomas,

Sorry for the late reply.

On Wed, Mar 10, 2021 at 2:49 AM Thomas Huth <thuth@redhat.com> wrote:
>
> On 09/03/2021 23.27, Philippe Mathieu-Daudé wrote:
> > ping?
>
> I guess we really need someone who could act as a maintainer for the
> tests/acceptance directory, who could pick up patches and send pull requests
> if nobody else is picking up these patches...
>
> Cleber, Wainer, Willian, any volunteers?
>

This is something I have discussed with Philippe some times already. I
understand the tests/acceptance directory is a gray area. I'm more
comfortable with the idea that subsystem maintainers are responsible
to send pull requests for tests related to them or, at least, ack
them. In case of a refactor or test improvement, someone else working
with testing core features could send the pull request.

I know Cleber has been sending pull requests with changes related to
the testing core (avocado_qemu) and changes related to tests
refactoring or code improvement. I would be more than happy to backup
him if needed.

Willian

>   Thomas
>
>
> > On 2/14/21 8:45 PM, Philippe Mathieu-Daudé wrote:
> >> Add a very quick test that runs a busybox binary in bFLT format:
> >>
> >>    $ avocado --show=app run -t linux_user tests/acceptance/load_bflt.py
> >>    JOB ID     : db94d5960ce564c50904d666a7e259148c27e88f
> >>    JOB LOG    : ~/avocado/job-results/job-2019-06-25T10.52-db94d59/job.log
> >>     (1/1) tests/acceptance/load_bflt.py:LoadBFLT.test_stm32: PASS (0.15 s)
> >>    RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 
> >> | CANCEL 0
> >>    JOB TIME   : 0.54 s
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >> Based-on: <20210214175912.732946-1-f4bug@amsat.org>
> >>    tests/acceptance: Extract QemuBaseTest from Test
> >>    tests/acceptance: Make pick_default_qemu_bin() more generic
> >>    tests/acceptance: Introduce QemuUserTest base class
> >> ---
> >>   tests/acceptance/load_bflt.py | 51 +++++++++++++++++++++++++++++++++++
> >>   1 file changed, 51 insertions(+)
> >>   create mode 100644 tests/acceptance/load_bflt.py
> >>
> >> diff --git a/tests/acceptance/load_bflt.py b/tests/acceptance/load_bflt.py
> >> new file mode 100644
> >> index 00000000000..4b7796d0775
> >> --- /dev/null
> >> +++ b/tests/acceptance/load_bflt.py
> >> @@ -0,0 +1,51 @@
> >> +# Test the bFLT format
> >> +#
> >> +# Copyright (C) 2019 Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> +#
> >> +# SPDX-License-Identifier: GPL-2.0-or-later
> >> +
> >> +import os
> >> +import bz2
> >> +import subprocess
> >> +
> >> +from avocado_qemu import QemuUserTest
> >> +
> >> +
> >> +class LoadBFLT(QemuUserTest):
> >> +
> >> +    def extract_cpio(self, cpio_path):
> >> +        """
> >> +        Extracts a cpio archive into the test workdir
> >> +
> >> +        :param cpio_path: path to the cpio archive
> >> +        """
> >> +        cwd = os.getcwd()
> >> +        os.chdir(self.workdir)
> >> +        with bz2.open(cpio_path, 'rb') as archive_cpio:
> >> +            subprocess.run(['cpio', '-i'], input=archive_cpio.read(),
> >> +                           stderr=subprocess.DEVNULL)
> >> +        os.chdir(cwd)
> >> +
> >> +    @skipUnless(os.getenv('AVOCADO_ALLOW_UNTRUSTED_CODE'), 'untrusted 
> >> code')
> >> +    def test_stm32(self):
> >> +        """
> >> +        :avocado: tags=arch:arm
> >> +        :avocado: tags=linux_user
> >> +        :avocado: tags=quick
> >> +        """
> >> +        # See https://elinux.org/STM32#User_Space
> >> +        rootfs_url = ('https://elinux.org/images/5/51/'
> >> +                      'Stm32_mini_rootfs.cpio.bz2')
> >> +        rootfs_hash = '9f065e6ba40cce7411ba757f924f30fcc57951e6'
> >> +        rootfs_path_bz2 = self.fetch_asset(rootfs_url, 
> >> asset_hash=rootfs_hash)
> >> +        busybox_path = self.workdir + "/bin/busybox"
> >> +
> >> +        self.extract_cpio(rootfs_path_bz2)
> >> +
> >> +        res = self.run(busybox_path)
> >> +        ver = 'BusyBox v1.24.0.git (2015-02-03 22:17:13 CET) multi-call 
> >> binary.'
> >> +        self.assertIn(ver, res.stdout_text)
> >> +
> >> +        res = self.run(busybox_path, ['uname', '-a'])
> >> +        unm = 'armv7l GNU/Linux'
> >> +        self.assertIn(unm, res.stdout_text)
> >>
> >
>