Re: [PATCH v3 1/3] target/arm: Add support for FEAT_TLBIRANGE

[Richard Henderson]

On 3/16/21 12:20 AM, Rebecca Cran wrote:
> On 3/10/21 12:24 PM, Richard Henderson wrote:
> > On 3/9/21 6:29 PM, Rebecca Cran wrote:
>
> > > +    uint64_t addr = (value & 0xFFFFFFFFFUL) << TARGET_PAGE_BITS;
> >
> > The manual does not explicitly say, but I'm certain that this should be a 
> > signed address, when regime_has_2_ranges().  Otherwise it would be impossible 
> > to flush a range of kernel addresses.
>
> I see other functions have
>
> uint64_t pageaddr = sextract(value...);
>
> Would that be sufficient here too, or do we need to check regime_has_2_ranges()?

We need to check the regime.

r~