|
| From: | Richard Henderson |
| Subject: | Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() |
| Date: | Sat, 13 Mar 2021 13:47:29 -0600 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/13/21 11:01 AM, Philippe Mathieu-Daudé wrote:
When QDev objects have their DeviceReset handler set, they shouldn't worry about calling it at realization stage (it is handled by hw/core/qdev.c::device_set_realized). Remove the pointless/confusing bcm2835_fb_reset() call. Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
| [Prev in Thread] | Current Thread | [Next in Thread] |