[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] hw/timer/sse-timer: Propagate eventual error in sse_timer_realiz
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH] hw/timer/sse-timer: Propagate eventual error in sse_timer_realize() |
Date: |
Fri, 12 Mar 2021 01:18:45 +0100 |
If the SSECounter link is absent, we set an error message
in sse_timer_realize() but forgot to propagate this error.
Add the missing 'return'.
Fixes: CID 1450755 (Null pointer dereferences)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/timer/sse-timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/timer/sse-timer.c b/hw/timer/sse-timer.c
index 8dbe6ac651e..f959cb9d603 100644
--- a/hw/timer/sse-timer.c
+++ b/hw/timer/sse-timer.c
@@ -415,6 +415,7 @@ static void sse_timer_realize(DeviceState *dev, Error
**errp)
if (!s->counter) {
error_setg(errp, "counter property was not set");
+ return;
}
s->counter_notifier.notify = sse_timer_counter_callback;
--
2.26.2
- [PATCH] hw/timer/sse-timer: Propagate eventual error in sse_timer_realize(),
Philippe Mathieu-Daudé <=