[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context
From: |
Eric Auger |
Subject: |
[PATCH v3 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate |
Date: |
Tue, 9 Mar 2021 11:27:36 +0100 |
With -Werror=maybe-uninitialized configuration we get
../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’:
../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
1888 | mask = ~mask;
| ~~~~~^~~~~~~
Add a g_assert_not_reached() to avoid the error.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2 -> v3:
- Added Philippe and Peter's R-b
---
hw/i386/intel_iommu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index b4f5094259..3206f379f8 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -1884,6 +1884,8 @@ static void vtd_context_device_invalidate(IntelIOMMUState
*s,
case 3:
mask = 7; /* Mask bit 2:0 in the SID field */
break;
+ default:
+ g_assert_not_reached();
}
mask = ~mask;
--
2.26.2
- [PATCH v3 0/7] Some vIOMMU fixes, Eric Auger, 2021/03/09
- [PATCH v3 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate,
Eric Auger <=
- [PATCH v3 3/7] virtio-iommu: Handle non power of 2 range invalidations, Eric Auger, 2021/03/09
- [PATCH v3 2/7] dma: Introduce dma_aligned_pow2_mask(), Eric Auger, 2021/03/09
- [PATCH v3 4/7] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set, Eric Auger, 2021/03/09
- [PATCH v3 5/7] hw/arm/smmuv3: Enforce invalidation on a power of two range, Eric Auger, 2021/03/09
- [PATCH v3 6/7] hw/arm/smmuv3: Fix SMMU_CMD_CFGI_STE_RANGE handling, Eric Auger, 2021/03/09
- [PATCH v3 7/7] hw/arm/smmuv3: Uniformize sid traces, Eric Auger, 2021/03/09