[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] aspeed: Emulate the AST2600A3
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] aspeed: Emulate the AST2600A3 |
|
Date: |
Thu, 4 Mar 2021 14:32:29 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/4/21 1:43 PM, Joel Stanley wrote:
> This is the latest revision of the ASPEED 2600 SoC.
>
> Reset values are taken from v8 of the datasheet.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> include/hw/misc/aspeed_scu.h | 2 ++
> hw/arm/aspeed_ast2600.c | 2 +-
> hw/misc/aspeed_scu.c | 32 +++++++++++++++++++++++++-------
> 3 files changed, 28 insertions(+), 8 deletions(-)
> -#define AST2600_CLK_SEL3 TO_REG(0x310)
> +#define AST2600_CLK_SEL3 TO_REG(0x308)
This register doesn't seem in use, still it would be
nice to mention this fix in the commit description.