[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 24/28] target/xtensa: Restrict watchpoint code to system emula
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 24/28] target/xtensa: Restrict watchpoint code to system emulation |
Date: |
Wed, 3 Mar 2021 22:47:04 +0100 |
We can not use watchpoints in user-mode emulation because we
need the softmmu slow path to detect accesses to watchpointed
memory. Add #ifdef'ry around it.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/xtensa/helper.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c
index eeffee297d1..85e466b37d2 100644
--- a/target/xtensa/helper.c
+++ b/target/xtensa/helper.c
@@ -201,6 +201,7 @@ void xtensa_register_core(XtensaConfigList *node)
g_free((gpointer)type.name);
}
+#ifndef CONFIG_USER_ONLY
static uint32_t check_hw_breakpoints(CPUXtensaState *env)
{
unsigned i;
@@ -213,9 +214,11 @@ static uint32_t check_hw_breakpoints(CPUXtensaState *env)
}
return 0;
}
+#endif
void xtensa_breakpoint_handler(CPUState *cs)
{
+#ifndef CONFIG_USER_ONLY
XtensaCPU *cpu = XTENSA_CPU(cs);
CPUXtensaState *env = &cpu->env;
@@ -231,6 +234,7 @@ void xtensa_breakpoint_handler(CPUState *cs)
cpu_loop_exit_noexc(cs);
}
}
+#endif
}
void xtensa_cpu_list(void)
--
2.26.2
- [PATCH v4 16/28] cpu: Restrict "hw/core/sysemu-cpu-ops.h" to target/cpu.c, (continued)
- [PATCH v4 16/28] cpu: Restrict "hw/core/sysemu-cpu-ops.h" to target/cpu.c, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 17/28] linux-user: Remove dead code, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 18/28] gdbstub: Remove watchpoint dead code in gdbserver_fork(), Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 19/28] target/arm/internals: Fix code style for checkpatch.pl, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 20/28] target/arm: Move code blocks around, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 21/28] target/arm: Refactor some function bodies, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 22/28] target/arm: Restrict watchpoint code to system emulation, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 23/28] target/i386: Restrict watchpoint code to system emulation, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 24/28] target/xtensa: Restrict watchpoint code to system emulation,
Philippe Mathieu-Daudé <=
- [PATCH v4 25/28] accel/tcg/cpu-exec: Restrict watchpoint code to system emulation, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 26/28] cpu: Remove watchpoint stubs for user emulation, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 27/28] cpu: Fix code style for checkpatch.pl, Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v4 28/28] cpu: Move sysemu specific declarations to 'sysemu-cpu-ops.h', Philippe Mathieu-Daudé, 2021/03/03
- Re: [PATCH v4 00/28] cpu: Introduce SysemuCPUOps structure, remove watchpoints from usermode, Richard Henderson, 2021/03/03