[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE
From: |
Richard Henderson |
Subject: |
[PATCH v5 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE |
Date: |
Wed, 3 Feb 2021 08:59:47 -1000 |
These constants are only ever used with access_ok, and friends.
Rather than translating them to PAGE_* bits, let them equal
the PAGE_* bits to begin.
Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
bsd-user/qemu.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
index f8bb1e5459..4076adabd0 100644
--- a/bsd-user/qemu.h
+++ b/bsd-user/qemu.h
@@ -218,13 +218,12 @@ extern unsigned long x86_stack_size;
/* user access */
-#define VERIFY_READ 0
-#define VERIFY_WRITE 1 /* implies read access */
+#define VERIFY_READ PAGE_READ
+#define VERIFY_WRITE (PAGE_READ | PAGE_WRITE)
-static inline int access_ok(int type, abi_ulong addr, abi_ulong size)
+static inline bool access_ok(int type, abi_ulong addr, abi_ulong size)
{
- return page_check_range((target_ulong)addr, size,
- (type == VERIFY_READ) ? PAGE_READ : (PAGE_READ |
PAGE_WRITE)) == 0;
+ return page_check_range((target_ulong)addr, size, type) == 0;
}
/* NOTE __get_user and __put_user use host pointers and don't check access. */
--
2.25.1
- Re: [PATCH v5 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged, (continued)
- [PATCH v5 14/31] linux-user: Use guest_range_valid in access_ok, Richard Henderson, 2021/02/03
- [PATCH v5 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, Richard Henderson, 2021/02/03
- [PATCH v5 27/31] linux-user/aarch64: Signal SEGV_MTESERR for sync tag check fault, Richard Henderson, 2021/02/03
- [PATCH v5 28/31] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error, Richard Henderson, 2021/02/03
- [PATCH v5 06/31] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/02/03
- [PATCH v5 04/31] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/02/03
- [PATCH v5 09/31] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/02/03
- [PATCH v5 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE,
Richard Henderson <=
- [PATCH v5 13/31] linux-user: Explicitly untag memory management syscalls, Richard Henderson, 2021/02/03
- [PATCH v5 16/31] linux-user: Use cpu_untagged_addr in access_ok; split out *_untagged, Richard Henderson, 2021/02/03
- [PATCH v5 17/31] linux-user: Move lock_user et al out of line, Richard Henderson, 2021/02/03
- [PATCH v5 18/31] linux-user: Fix types in uaccess.c, Richard Henderson, 2021/02/03
- [PATCH v5 19/31] linux-user: Handle tags in lock_user/unlock_user, Richard Henderson, 2021/02/03