[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/net/lan9118: Add symbolic constants for register offs
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 2/2] hw/net/lan9118: Add symbolic constants for register offsets |
|
Date: |
Fri, 8 Jan 2021 19:16:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/8/21 7:04 PM, Peter Maydell wrote:
> The lan9118 code mostly uses symbolic constants for register offsets;
> the exceptions are those which the datasheet doesn't give an official
> symbolic name to.
>
> Add some names for the registers which don't already have them, based
> on the longer names they are given in the memory map.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/net/lan9118.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>