Re: [PATCH 0/2] Remove GCC < 4.8 checks

[no-reply]

Patchew URL: 
20201124125235.266884-1-marcandre.lureau@redhat.com/">https://patchew.org/QEMU/20201124125235.266884-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201124125235.266884-1-marcandre.lureau@redhat.com
Subject: [PATCH 0/2] Remove GCC < 4.8 checks

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201124122936.30588-1-kraxel@redhat.com -> 
patchew/20201124122936.30588-1-kraxel@redhat.com
 * [new tag]         
patchew/20201124125235.266884-1-marcandre.lureau@redhat.com -> 
patchew/20201124125235.266884-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
c9fd76f compiler.h: remove QEMU_GNUC_PREREQ macro
4428f55 Remove GCC version checks (all < 4.8)

=== OUTPUT BEGIN ===
1/2 Checking commit 4428f552871c (Remove GCC version checks (all < 4.8))
WARNING: architecture specific defines should be avoided
#22: FILE: accel/tcg/cpu-exec.c:727:
+#if defined(__clang__)

WARNING: Block comments use a leading /* on a separate line
#86: FILE: include/qemu/compiler.h:105:
+   /* Map __printf__ to __gnu_printf__ because we want standard format strings

WARNING: Block comments use a trailing */ on a separate line
#87: FILE: include/qemu/compiler.h:106:
+    * even when MinGW or GLib include files use __printf__. */

ERROR: space prohibited between function name and open parenthesis '('
#129: FILE: tests/tcg/arm/fcvt.c:76:
+# define SNANF (__builtin_nansf (""))

ERROR: space prohibited between function name and open parenthesis '('
#130: FILE: tests/tcg/arm/fcvt.c:77:
+# define SNAN (__builtin_nans (""))

ERROR: space prohibited between function name and open parenthesis '('
#131: FILE: tests/tcg/arm/fcvt.c:78:
+# define SNANL (__builtin_nansl (""))

WARNING: architecture specific defines should be avoided
#146: FILE: tools/virtiofsd/fuse_common.h:813:
+#if defined(__GNUC__) && !defined __cplusplus

total: 3 errors, 4 warnings, 106 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit c9fd76f82866 (compiler.h: remove QEMU_GNUC_PREREQ macro)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201124125235.266884-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201124125235.266884-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com