[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator
From: |
Thomas Huth |
Subject: |
Re: [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator |
Date: |
Thu, 22 Oct 2020 07:58:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 21/10/2020 23.35, Havard Skinnemoen via wrote:
> The RNG module returns a byte of randomness when the Data Valid bit is
> set.
>
> This implementation ignores the prescaler setting, and loads a new value
> into RNGD every time RNGCS is read while the RNG is enabled and random
> data is available.
>
> A qtest featuring some simple randomness tests is included.
>
> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
> ---
[...]
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index f7b0e3ca9d..473935c3a8 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -140,6 +140,7 @@ qtests_arm = \
> 'm25p80-test',
> 'npcm7xx_timer-test',
> 'npcm7xx_watchdog_timer-test',
> + 'npcm7xx_rng-test',
> 'test-arm-mptimer',
> 'boot-serial-test',
> 'hexloader-test']
Please fence this with CONFIG_NPCM7XX, too.
Thanks,
Thomas
- [PATCH v2 0/5] Additional NPCM7xx features, devices and tests, Havard Skinnemoen, 2020/10/21
- [PATCH v2 1/5] Move npcm7xx_timer_reached_zero call out of npcm7xx_timer_pause, Havard Skinnemoen, 2020/10/21
- [PATCH v2 4/5] hw/arm/npcm7xx: Add EHCI and OHCI controllers, Havard Skinnemoen, 2020/10/21
- [PATCH v2 2/5] hw/timer: Adding watchdog for NPCM7XX Timer., Havard Skinnemoen, 2020/10/21
- [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator, Havard Skinnemoen, 2020/10/21
- Re: [PATCH v2 3/5] hw/misc: Add npcm7xx random number generator,
Thomas Huth <=
- [PATCH v2 5/5] hw/gpio: Add GPIO model for Nuvoton NPCM7xx, Havard Skinnemoen, 2020/10/21