[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 33/45] target/arm: Implement fp16 for Neon VRECPS
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 33/45] target/arm: Implement fp16 for Neon VRECPS |
|
Date: |
Fri, 28 Aug 2020 16:02:23 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/28/20 11:33 AM, Peter Maydell wrote:
> Convert the Neon VRECPS insn to using a gvec helper, and
> use this to implement the fp16 case.
>
> The phrasing of the new float32_recps_nf() is slightly different from
> the old recps_f32() so that it parallels the f16 version; for f16 we
> can't assume that flush-to-zero is always enabled.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/helper.h | 4 +++-
> target/arm/vec_helper.c | 31 +++++++++++++++++++++++++++++++
> target/arm/vfp_helper.c | 13 -------------
> target/arm/translate-neon.c.inc | 21 +--------------------
> 4 files changed, 35 insertions(+), 34 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v2 20/45] target/arm: Implement new VFP fp16 insn VMOVX, (continued)
- [PATCH v2 20/45] target/arm: Implement new VFP fp16 insn VMOVX, Peter Maydell, 2020/08/28
- [PATCH v2 27/45] target/arm: Implement fp16 for VACGE, VACGT, Peter Maydell, 2020/08/28
- [PATCH v2 29/45] target/arm: Implement fp16 for Neon VMAXNM, VMINNM, Peter Maydell, 2020/08/28
- [PATCH v2 31/45] target/arm: Implement fp16 for Neon VFMA, VMFS, Peter Maydell, 2020/08/28
- [PATCH v2 30/45] target/arm: Implement fp16 for Neon VMLA, VMLS operations, Peter Maydell, 2020/08/28
- [PATCH v2 33/45] target/arm: Implement fp16 for Neon VRECPS, Peter Maydell, 2020/08/28
- Re: [PATCH v2 33/45] target/arm: Implement fp16 for Neon VRECPS,
Richard Henderson <=
- [PATCH v2 32/45] target/arm: Implement fp16 for Neon fp compare-vs-0, Peter Maydell, 2020/08/28
- [PATCH v2 34/45] target/arm: Implement fp16 for Neon VRSQRTS, Peter Maydell, 2020/08/28
- [PATCH v2 35/45] target/arm: Implement fp16 for Neon pairwise fp ops, Peter Maydell, 2020/08/28
- [PATCH v2 36/45] target/arm: Implement fp16 for Neon float-integer VCVT, Peter Maydell, 2020/08/28
- [PATCH v2 37/45] target/arm: Convert Neon VCVT fixed-point to gvec, Peter Maydell, 2020/08/28