[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/58] pl110: Rename pl110_version enum values
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 04/58] pl110: Rename pl110_version enum values |
|
Date: |
Thu, 20 Aug 2020 15:11:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 8/20/20 2:11 AM, Eduardo Habkost wrote:
> The PL110 enum value name will conflict with the PL110 type cast
> checker, when we replace the existing macro with an inline
> function. Add a VERSION_ prefix to all pl110_version enum
> values, to avoid conflicts.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Fixed typo on commit message
> * Rename all enum values to VERSION_* (Philippe Mathieu-Daudé)
>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> hw/display/pl110.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>