Re: [PATCH v2 2/2] target/arm: Fix compile error.

[Kaige Li]

On 07/31/2020 04:45 AM, Peter Maydell wrote:

> On Thu, 30 Jul 2020 at 12:58, Kaige Li <likaige@loongson.cn> wrote:
> > When I compile qemu with such as:
> >
> > git clone https://git.qemu.org/git/qemu.git
> > cd qemu
> > git submodule init
> > git submodule update --recursive
> > ./configure
> > make
> >
> > There is error log:
> >
> > /home/LiKaige/qemu/target/arm/translate-a64.c: In function ‘disas_ldst’:
> > /home/LiKaige/qemu/target/arm/translate-a64.c:3392:5: error: ‘fn’ may be used 
> > uninitialized in this function [-Werror=maybe-uninitialized]
> >       fn(cpu_reg(s, rt), clean_addr, tcg_rs, get_mem_index(s),
> >       ^
> > /home/LiKaige/qemu/target/arm/translate-a64.c:3318:22: note: ‘fn’ was declared 
> > here
> >       AtomicThreeOpFn *fn;
> >                        ^
> > cc1: all warnings being treated as errors
> >
> > So, add an initiallization value NULL for fn to fix this.
> >
> > Signed-off-by: Kaige Li <likaige@loongson.cn>
> Hi; I've taken this patch (but not patch 1 in the series)
> into target-arm.next, with the commit message cleaned up
> to quote the compiler version.
Hi, did you mean I should commit this patch separately, not in a series 
of patches?
and the submission information should be added to the gcc version and 
cpu architecture?

Thanks for your patience and suggestion .
Kaige.
> thanks
> -- PMM