Re: [PATCH for-5.1 3/4] docs/system: Briefly document gumstix boards

[Philippe Mathieu-Daudé]

On 7/13/20 7:57 PM, Peter Maydell wrote:
> Add skeletal documentation of the gumstix boards
> ('connex' and 'verdex').
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  docs/system/arm/gumstix.rst | 21 +++++++++++++++++++++
>  docs/system/target-arm.rst  |  1 +
>  MAINTAINERS                 |  1 +
>  3 files changed, 23 insertions(+)
>  create mode 100644 docs/system/arm/gumstix.rst
> 
> diff --git a/docs/system/arm/gumstix.rst b/docs/system/arm/gumstix.rst
> new file mode 100644
> index 00000000000..805e0f8d5df
> --- /dev/null
> +++ b/docs/system/arm/gumstix.rst
> @@ -0,0 +1,21 @@
> +Gumstix Connex and Verdex (``connex``, ``verdex``)
> +==================================================
> +
> +These machines model the Gumstix Connex and Verdex boards.
> +The Connex has a PXA255 CPU and the Verdex has a PXA270.
> +
> +Implemented devices:
> +
> + * Flash

Maybe "NOR flash"?

> + * SMC91C111 ethernet
> + * Interrupt controller

Most of the peripherals are controllers =)
This sounds better then raw 'interrupts'.

> + * DMA
> + * Timer
> + * GPIO
> + * MMC/SD card
> + * FIR

'Fast Infra-Red communications port'?

> + * LCDC

'LCD controller'

> + * SSP

I think only SPI is implemented.

Maybe: 'Synchronous Serial Ports (SPI)'

> + * PC Card sockets

'PCMCIA interface'?

> + * I2C
> + * I2S
> diff --git a/docs/system/target-arm.rst b/docs/system/target-arm.rst
> index 376c18f0b17..163ab915592 100644
> --- a/docs/system/target-arm.rst
> +++ b/docs/system/target-arm.rst
> @@ -84,6 +84,7 @@ undocumented; you can get a complete list by running
>     arm/aspeed
>     arm/digic
>     arm/musicpal
> +   arm/gumstix
>     arm/nseries
>     arm/orangepi
>     arm/palm
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 048b2d41729..286b076da89 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -650,6 +650,7 @@ R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  L: qemu-arm@nongnu.org
>  S: Odd Fixes
>  F: hw/arm/gumstix.c
> +F: docs/system/arm/gumstix.rst

Feel free to take better descriptions or as it:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>  
>  i.MX25 PDK
>  M: Peter Maydell <peter.maydell@linaro.org>
>