Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation

[Philippe Mathieu-Daudé]

Corey, this series is now fully reviewed :)

On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote:
> In commit d88c42ff2c we added 2 methods: i2c_try_create_slave()
> and i2c_realize_and_unref().
> Markus noted their name could be improved for consistency [1],
> and Peter reported the lack of documentation [2]. Fix that now.
> 
> Since v1:
> - Addressed Markus review comments
> - Added Markus/Corey R-b tags
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg07060.html
> [2] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg08997.html
> 
> $ git backport-diff -u -v1
> Key:
> [----] : patches are identical
> [####] : number of functional differences between upstream/downstream patch
> [down] : patch is downstream-only
> The flags [FC] indicate (F)unctional and (C)ontextual differences, 
> respectively
> 
> 001/5:[----] [--] 'hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()'
> 002/5:[0006] [FC] 'hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()'
> 003/5:[0004] [FC] 'hw/i2c: Rename i2c_realize_and_unref() as 
> i2c_slave_realize_and_unref()'
> 004/5:[0006] [FC] 'hw/i2c: Rename i2c_create_slave() as 
> i2c_slave_create_simple()'
> 005/5:[0012] [FC] 'hw/i2c: Document the I2C qdev helpers'