[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset |
Date: |
Fri, 10 Jul 2020 10:08:56 +0100 |
On Wed, 8 Jul 2020 at 15:20, Eric Auger <eric.auger@redhat.com> wrote:
>
> The SMMU IIDR register is at 0x018 offset.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Fixes: 10a83cb9887 ("hw/arm/smmuv3: Skeleton")
> ---
> hw/arm/smmuv3-internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
> index 5babf72f7d..ef093eaff5 100644
> --- a/hw/arm/smmuv3-internal.h
> +++ b/hw/arm/smmuv3-internal.h
> @@ -63,7 +63,7 @@ REG32(IDR5, 0x14)
>
> #define SMMU_IDR5_OAS 4
>
> -REG32(IIDR, 0x1c)
> +REG32(IIDR, 0x18)
> REG32(CR0, 0x20)
> FIELD(CR0, SMMU_ENABLE, 0, 1)
> FIELD(CR0, EVENTQEN, 2, 1)
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v3 01/11] hw/arm/smmu-common: Factorize some code in smmu_ptw_64(), (continued)
- [PATCH v3 01/11] hw/arm/smmu-common: Factorize some code in smmu_ptw_64(), Eric Auger, 2020/07/08
- [PATCH v3 02/11] hw/arm/smmu-common: Add IOTLB helpers, Eric Auger, 2020/07/08
- [PATCH v3 07/11] hw/arm/smmuv3: Get prepared for range invalidation, Eric Auger, 2020/07/08
- [PATCH v3 10/11] hw/arm/smmuv3: Support HAD and advertise SMMUv3.1 support, Eric Auger, 2020/07/08
- [PATCH v3 04/11] hw/arm/smmu: Introduce SMMUTLBEntry for PTW and IOTLB value, Eric Auger, 2020/07/08
- [PATCH v3 09/11] hw/arm/smmuv3: Let AIDR advertise SMMUv3.0 support, Eric Auger, 2020/07/08
- [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset, Eric Auger, 2020/07/08
- Re: [PATCH v3 08/11] hw/arm/smmuv3: Fix IIDR offset,
Peter Maydell <=
- [PATCH v3 11/11] hw/arm/smmuv3: Advertise SMMUv3.2 range invalidation, Eric Auger, 2020/07/08
- [PATCH v3 06/11] hw/arm/smmuv3: Introduce smmuv3_s1_range_inval() helper, Eric Auger, 2020/07/08