[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/10] hw/sd/sdcard: make sd_data_ready() static
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v4 09/10] hw/sd/sdcard: make sd_data_ready() static |
Date: |
Sun, 5 Jul 2020 22:46:29 +0200 |
sd_data_ready() belongs to the legacy API. As its last user has
been converted to the SDBus API, make it static.
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Message-Id: <20180216022933.10945-7-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/sd/sd.h | 1 -
hw/sd/sd.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h
index a84b8e274a..ace350e0e8 100644
--- a/include/hw/sd/sd.h
+++ b/include/hw/sd/sd.h
@@ -143,7 +143,6 @@ int sd_do_command(SDState *sd, SDRequest *req,
void sd_write_data(SDState *sd, uint8_t value);
uint8_t sd_read_data(SDState *sd);
void sd_set_cb(SDState *sd, qemu_irq readonly, qemu_irq insert);
-bool sd_data_ready(SDState *sd);
/* sd_enable should not be used -- it is only used on the nseries boards,
* where it is part of a broken implementation of the MMC card slot switch
* (there should be two card slots which are multiplexed to a single MMC
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 97a9d32964..54b1414131 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2059,7 +2059,7 @@ uint8_t sd_read_data(SDState *sd)
return ret;
}
-bool sd_data_ready(SDState *sd)
+static bool sd_data_ready(SDState *sd)
{
return sd->state == sd_sendingdata_state;
}
--
2.21.3
- Re: [PATCH v4 04/10] hw/arm/versatilepb: Comment to remember some IRQs lines are left unwired, (continued)
- [PATCH v4 05/10] hw/sd/pl181: Use named GPIOs, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v4 06/10] hw/sd/pl181: Expose a SDBus and connect the SDCard to it, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v4 07/10] hw/sd/pl181: Do not create SD card within the SDHCI controller, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v4 08/10] hw/sd/pl181: Replace disabled fprintf()s by trace events, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v4 09/10] hw/sd/sdcard: make sd_data_ready() static,
Philippe Mathieu-Daudé <=
- [PATCH v4 10/10] hw/sd: move sdcard legacy API to 'hw/sd/sdcard_legacy.h', Philippe Mathieu-Daudé, 2020/07/05
- Re: [PATCH v4 00/10] hw/sd: convert legacy SDHCI devices to the SDBus API, Peter Maydell, 2020/07/09