qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field


From: Alistair Francis
Subject: Re: [PATCH] hw/arm/bcm2836: Remove unused 'cpu_type' field
Date: Sat, 4 Jul 2020 20:02:16 -0700

On Fri, Jul 3, 2020 at 1:05 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The 'cpu_type' has been moved from BCM283XState to BCM283XClass
> in commit 210f47840d, but we forgot to remove the old variable.
> Do it now.
>
> Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/arm/bcm2836.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/arm/bcm2836.h b/include/hw/arm/bcm2836.h
> index 024af8aae4..79dfff9d73 100644
> --- a/include/hw/arm/bcm2836.h
> +++ b/include/hw/arm/bcm2836.h
> @@ -33,7 +33,6 @@ typedef struct BCM283XState {
>      DeviceState parent_obj;
>      /*< public >*/
>
> -    char *cpu_type;
>      uint32_t enabled_cpus;
>
>      struct {
> --
> 2.21.3
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]