[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: hw/misc/aspeed_scu: 5d971f9e breaks Supermicro AST2400
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: hw/misc/aspeed_scu: 5d971f9e breaks Supermicro AST2400 |
Date: |
Tue, 30 Jun 2020 17:29:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Erik,
On 6/30/20 5:11 PM, Erik Smit wrote:
> Hello,
>
> 5d971f9e memory: Revert "memory: accept mismatching sizes in
> memory_region_access_valid" breaks Supermicro AST2400 u-boot.
> Supermicro AST2500 u-boot is fine.
>
> The u-boot tries to make a 2-byte read from address 0x84, but
> aspeed_ast2400_scu_ops has min_access = 4. When I change min_access to
> 2 or revert above commit, u-boot boots again.
>
> Is changing min_access to 2 the right way to fix this?
If you have access to the datasheet and can verify, then yes.
Else I suppose Cédric, Andrew or Joel can check for you.
> Should I send a patch to qemu-devel for this?
Yes :)
>
> Best regards,
>
> Erik Smit
>
> P.S.: I'm not subscribed to the mailing list, please Cc me on replies.
>