[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/17] hw/arm/spitz: Use max111x properties to set initial va
From: |
Peter Maydell |
Subject: |
Re: [PATCH 09/17] hw/arm/spitz: Use max111x properties to set initial values |
Date: |
Mon, 29 Jun 2020 15:05:21 +0100 |
On Mon, 29 Jun 2020 at 10:09, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 6/28/20 4:24 PM, Peter Maydell wrote:
> > Use the new max111x qdev properties to set the initial input
> > values rather than calling max111x_set_input(); this means that
> > on system reset the inputs will correctly return to their initial
> > values.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> Actually for arrays it would be nice to use:
>
> DEFINE_PROP_ARRAY("input", MAX111xState, nr_inputs, reset_input,
> qdev_prop_uint8, uint8_t),
DEFINE_PROP_ARRAY defines a variable length property array;
what we want for max111x is fixed-length.
thanks
-- PMM
- Re: [PATCH 07/17] hw/misc/max111x: Don't use vmstate_register(), (continued)
- [PATCH 06/17] hw/misc/max111x: provide QOM properties for setting initial values, Peter Maydell, 2020/06/28
- [PATCH 08/17] ssi: Add ssi_realize_and_unref(), Peter Maydell, 2020/06/28
- [PATCH 09/17] hw/arm/spitz: Use max111x properties to set initial values, Peter Maydell, 2020/06/28
- [PATCH 10/17] hw/misc/max111x: Use GPIO lines rather than max111x_set_input(), Peter Maydell, 2020/06/28
- [PATCH 11/17] hw/misc/max111x: Create header file for documentation, TYPE_ macros, Peter Maydell, 2020/06/28
- [PATCH 12/17] hw/arm/spitz: Encapsulate misc GPIO handling in a device, Peter Maydell, 2020/06/28
- [PATCH 13/17] hw/gpio/zaurus.c: Use LOG_GUEST_ERROR for bad guest register accesses, Peter Maydell, 2020/06/28