Re: [PATCH v6 2/5] virtio-iommu: Implement RESV_MEM probe request

[Auger Eric]

Hi Markus,

On 6/27/20 9:08 AM, Markus Armbruster wrote:
> Eric Auger <eric.auger@redhat.com> writes:
> 
>> This patch implements the PROBE request. At the moment,
>> only THE RESV_MEM property is handled. The first goal is
>> to report iommu wide reserved regions such as the MSI regions
>> set by the machine code. On x86 this will be the IOAPIC MSI
>> region, [0xFEE00000 - 0xFEEFFFFF], on ARM this may be the ITS
>> doorbell.
>>
>> In the future we may introduce per device reserved regions.
>> This will be useful when protecting host assigned devices
>> which may expose their own reserved regions
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>>
>> ---
>>
>> v5 -> v6:
>> - removed validation of s->reserved_regions[i].type in the
>>   probe request as it should rather happen in the realize()
> 
> Consider keeping the assertion.  I'd makes it locally obvious that the
> assignment to subtype is not supposed to truncate.  The realize method
> is in another file.  This is not a demand.

OK I will add the assert again

Thanks

Eric
> 
> [...]
>