[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 07/22] arm/cpuhp: Init PMU at host for all possible vcpus
From: |
Andrew Jones |
Subject: |
Re: [PATCH RFC 07/22] arm/cpuhp: Init PMU at host for all possible vcpus |
Date: |
Tue, 23 Jun 2020 11:00:43 +0200 |
On Sat, Jun 13, 2020 at 10:36:14PM +0100, Salil Mehta wrote:
> PMU for all possible vcpus must be initialized at the virt machine
> initialization time. This patch refactors existing code to accomodate possible
> vcpus. This also assumes that all processor being used are identical at least
> for now but does not affect the normal scanarios where they might not be in
> future. This assumption only affects the future hotplug scenarios if ever
> there
> exists any hetergenous processors. In such a case PMU might not be enabled on
> some vcpus. Is it acceptable and doable tradeoff for now?
>
> This perhaps needs more discussion. please check below link,
> Link: https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg00131.html
>
> Co-developed-by: Keqian Zhu <zhukeqian1@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
> hw/arm/virt.c | 51 ++++++++++++++++++++++++++++++-------------
> include/hw/arm/virt.h | 1 +
> 2 files changed, 37 insertions(+), 15 deletions(-)
>
I have a similar patch to this one in my steal-time dev branch that I just
started last week. I'm creating a new function that must be called after
cpu realization and gic creation that completes cpu setup. There's a few
things that will end up there (including steal-time stuff).
Thanks,
drew
- [PATCH RFC 00/22] Support of Virtual CPU Hotplug for ARMv8 Arch, Salil Mehta, 2020/06/13
- [PATCH RFC 01/22] arm/cpuhp: Add QMP vcpu params validation support, Salil Mehta, 2020/06/13
- [PATCH RFC 02/22] arm/cpuhp: Add new ARMCPU core-id property, Salil Mehta, 2020/06/13
- [PATCH RFC 03/22] arm/cpuhp: Add common cpu utility for possible vcpus, Salil Mehta, 2020/06/13
- [PATCH RFC 05/22] arm/cpuhp: Pre-create disabled possible vcpus @machine init, Salil Mehta, 2020/06/13
- [PATCH RFC 04/22] arm/cpuhp: Machine init time change common to vcpu {cold|hot}-plug, Salil Mehta, 2020/06/13
- [PATCH RFC 06/22] arm/cpuhp: Changes to pre-size GIC with possible vcpus @machine init, Salil Mehta, 2020/06/13
- [PATCH RFC 07/22] arm/cpuhp: Init PMU at host for all possible vcpus, Salil Mehta, 2020/06/13
- Re: [PATCH RFC 07/22] arm/cpuhp: Init PMU at host for all possible vcpus,
Andrew Jones <=
- [PATCH RFC 08/22] arm/cpuhp: Enable ACPI support for vcpu hotplug, Salil Mehta, 2020/06/13
- [PATCH RFC 09/22] arm/cpuhp: Init GED framework with cpu hotplug events, Salil Mehta, 2020/06/13
- [PATCH RFC 10/22] arm/cpuhp: Update CPUs AML with cpu-(ctrl)dev change, Salil Mehta, 2020/06/13
- [PATCH RFC 11/22] arm/cpuhp: Update GED _EVT method AML with cpu scan, Salil Mehta, 2020/06/13
- [PATCH RFC 12/22] arm/cpuhp: MADT Tbl change to size the guest with possible vcpus, Salil Mehta, 2020/06/13
- [PATCH RFC 13/22] arm/cpuhp: Add ACPI _MAT entry for Processor object, Salil Mehta, 2020/06/13
- [PATCH RFC 14/22] arm/cpuhp: Release objects for *disabled* possible vcpus after init, Salil Mehta, 2020/06/13
- [PATCH RFC 15/22] arm/cpuhp: Update ACPI GED framework to support vcpu hotplug, Salil Mehta, 2020/06/13
- [PATCH RFC 16/22] arm/cpuhp: Add/update basic hot-(un)plug framework, Salil Mehta, 2020/06/13