[PATCH v3 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1

[Philippe Mathieu-Daudé]

The Witherspoon has 3 LEDs connected to a PCA9552. Add them.
The names and reset values are taken from:
https://github.com/open-power/witherspoon-xml/blob/master/witherspoon.xml

Example booting obmc-phosphor-image:

  $ qemu-system-arm -M witherspoon-bmc -trace led_change_intensity
  1592693373.997015:led_change_intensity LED desc:'front-fault-4' color:green 
intensity 0x0000 -> 0xffff
  1592693373.997632:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0x0000 -> 0xffff
  1592693373.998239:led_change_intensity LED desc:'front-id-5' color:green 
intensity 0x0000 -> 0xffff
  1592693500.291805:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0xffff -> 0x0000
  1592693500.312041:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0x0000 -> 0xffff
  1592693500.821254:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0xffff -> 0x0000
  1592693501.331517:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0x0000 -> 0xffff
  1592693501.841367:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0xffff -> 0x0000
  1592693502.350839:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0x0000 -> 0xffff
  1592693502.861134:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0xffff -> 0x0000
  1592693503.371090:led_change_intensity LED desc:'front-power-3' color:green 
intensity 0x0000 -> 0xffff

We notice the front-power LED starts to blink.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/arm/aspeed.c | 17 +++++++++++++++++
 hw/arm/Kconfig  |  1 +
 2 files changed, 18 insertions(+)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 3d5dec4692..217f8ad7d5 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -20,6 +20,7 @@
 #include "hw/i2c/smbus_eeprom.h"
 #include "hw/misc/pca9552.h"
 #include "hw/misc/tmp105.h"
+#include "hw/misc/led.h"
 #include "hw/qdev-properties.h"
 #include "qemu/log.h"
 #include "sysemu/block-backend.h"
@@ -506,6 +507,16 @@ static void sonorapass_bmc_i2c_init(AspeedBoardState *bmc)
 
 static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)
 {
+    static const struct {
+        unsigned gpio_id;
+        LEDColor color;
+        const char *description;
+        uint16_t reset_intensity;
+    } pca1_leds[] = {
+        {13, LED_COLOR_GREEN, "front-fault-4",  
LED_RESET_INTENSITY_ACTIVE_LOW},
+        {14, LED_COLOR_GREEN, "front-power-3",  
LED_RESET_INTENSITY_ACTIVE_LOW},
+        {15, LED_COLOR_GREEN, "front-id-5",     
LED_RESET_INTENSITY_ACTIVE_LOW},
+    };
     AspeedSoCState *soc = &bmc->soc;
     uint8_t *eeprom_buf = g_malloc0(8 * 1024);
     DeviceState *dev;
@@ -518,6 +529,12 @@ static void witherspoon_bmc_i2c_init(AspeedBoardState *bmc)
     i2c_realize_and_unref(dev, aspeed_i2c_get_bus(DEVICE(&soc->i2c), 3),
                           &error_fatal);
 
+    for (size_t i = 0; i < ARRAY_SIZE(pca1_leds); i++) {
+        create_led_by_gpio_id(OBJECT(bmc), dev,
+                              pca1_leds[i].gpio_id, pca1_leds[i].color,
+                              pca1_leds[i].description,
+                              pca1_leds[i].reset_intensity);
+    }
     i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 4), "tmp423", 0x4c);
     i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 5), "tmp423", 0x4c);
 
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 9afa6eee79..1a57a861ac 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -393,6 +393,7 @@ config ASPEED_SOC
     select TMP105
     select TMP421
     select UNIMP
+    select LED
 
 config MPS2
     bool
-- 
2.21.3