[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 21/21] target/arm: Move some functions used only in translate
From: |
Richard Henderson |
Subject: |
Re: [PATCH 21/21] target/arm: Move some functions used only in translate-neon.inc.c to that file |
Date: |
Fri, 19 Jun 2020 17:21:03 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/16/20 10:08 AM, Peter Maydell wrote:
> The functions neon_element_offset(), neon_load_element(),
> neon_load_element64(), neon_store_element() and
> neon_store_element64() are used only in the translate-neon.inc.c
> file, so move their definitions there.
>
> Since the .inc.c file is #included in translate.c this doesn't make
> much difference currently, but it's a more logical place to put the
> functions and it might be helpful if we ever decide to try to make
> the .inc.c files genuinely separate compilation units.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/translate-neon.inc.c | 101 ++++++++++++++++++++++++++++++++
> target/arm/translate.c | 101 --------------------------------
> 2 files changed, 101 insertions(+), 101 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- Re: [PATCH 16/21] target/arm: Convert Neon 2-reg-misc fp-compare-with-zero insns to decodetree, (continued)
- [PATCH 17/21] target/arm: Convert Neon 2-reg-misc VRINT insns to decodetree, Peter Maydell, 2020/06/16
- [PATCH 18/21] target/arm: Convert Neon 2-reg-misc VCVT insns to decodetree, Peter Maydell, 2020/06/16
- [PATCH 19/21] target/arm: Convert Neon VSWP to decodetree, Peter Maydell, 2020/06/16
- [PATCH 20/21] target/arm: Convert Neon VTRN to decodetree, Peter Maydell, 2020/06/16
- [PATCH 21/21] target/arm: Move some functions used only in translate-neon.inc.c to that file, Peter Maydell, 2020/06/16
- Re: [PATCH 21/21] target/arm: Move some functions used only in translate-neon.inc.c to that file,
Richard Henderson <=
- Re: [PATCH 00/21] target/arm: Finish neon decodetree conversion, no-reply, 2020/06/16
- Re: [PATCH 00/21] target/arm: Finish neon decodetree conversion, no-reply, 2020/06/16