[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU) |
|
Date: |
Thu, 18 Jun 2020 12:59:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 18/06/20 10:57, Andrew Jones wrote:
>> If it's a test that the feature is enabled (e.g. via -cpu) then I agree.
>> For something that ends up as a KVM_CHECK_EXTENSION or KVM_ENABLE_CAP on
>> the KVM fd, however, I think passing an AccelState is better.
> I can live with that justification as long as we don't support
> heterogeneous VCPU configurations. And, if that ever happens, then I
> guess we'll be reworking a lot more than just the interface of these
> cpu feature probes.
Yes, and anyway configuring "what is allowed" would be separate from
checking "what is supported".
Thanks,