[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/10] target/arm: Convert Neon VTBL, VTBX to decodetree
From: |
Richard Henderson |
Subject: |
Re: [PATCH 09/10] target/arm: Convert Neon VTBL, VTBX to decodetree |
Date: |
Thu, 11 Jun 2020 09:45:50 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/11/20 7:45 AM, Peter Maydell wrote:
> +static bool trans_VTBL(DisasContext *s, arg_VTBL *a)
> +{
> + int n;
> + TCGv_i32 tmp, tmp2, tmp3, tmp4;
> + TCGv_ptr ptr1;
> +
> + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) {
> + return false;
> + }
> +
> + /* UNDEF accesses to D16-D31 if they don't exist. */
> + if (!dc_isar_feature(aa32_simd_r32, s) &&
> + ((a->vd | a->vn | a->vm) & 0x10)) {
> + return false;
> + }
> +
> + if (!vfp_access_check(s)) {
> + return true;
> + }
> +
> + n = a->len + 1;
> + if ((a->vn + n) > 32) {
> + /*
> + * This is UNPREDICTABLE; we choose to UNDEF to avoid the
> + * helper function running off the end of the register file.
> + */
> + return 1;
> + }
Oops, meant to point out: return false.
r~
- [PATCH 03/10] target/arm: Convert Neon 2-reg-scalar integer multiplies to decodetree, (continued)
- [PATCH 03/10] target/arm: Convert Neon 2-reg-scalar integer multiplies to decodetree, Peter Maydell, 2020/06/11
- [PATCH 04/10] target/arm: Convert Neon 2-reg-scalar float multiplies to decodetree, Peter Maydell, 2020/06/11
- [PATCH 06/10] target/arm: Convert Neon 2-reg-scalar VQRDMLAH, VQRDMLSH to decodetree, Peter Maydell, 2020/06/11
- [PATCH 07/10] target/arm: Convert Neon 2-reg-scalar long multiplies to decodetree, Peter Maydell, 2020/06/11
- [PATCH 09/10] target/arm: Convert Neon VTBL, VTBX to decodetree, Peter Maydell, 2020/06/11
- [PATCH 05/10] target/arm: Convert Neon 2-reg-scalar VQDMULH, VQRDMULH to decodetree, Peter Maydell, 2020/06/11
- [PATCH 08/10] target/arm: Convert Neon VEXT to decodetree, Peter Maydell, 2020/06/11
- [PATCH 10/10] target/arm: Convert Neon VDUP (scalar) to decodetree, Peter Maydell, 2020/06/11
- Re: [PATCH 00/10] target/arm: Convert 2-reg-scalar to decodetree, no-reply, 2020/06/11
- Re: [PATCH 00/10] target/arm: Convert 2-reg-scalar to decodetree, no-reply, 2020/06/11