Re: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree

[no-reply]

Patchew URL: 
20200609160209.29960-1-peter.maydell@linaro.org/">https://patchew.org/QEMU/20200609160209.29960-1-peter.maydell@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200609160209.29960-1-peter.maydell@linaro.org
Subject: [PATCH 0/7] target/arm: Convert Neon 3-reg-diff to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   49ee115..31d321c  master     -> master
Switched to a new branch 'test'
fb9cd52 target/arm: Convert Neon 3-reg-diff polynomial VMULL
08c5030 target/arm: Convert Neon 3-reg-diff saturating doubling multiplies
df05eae target/arm: Convert Neon 3-reg-diff long multiplies
42bfcfc target/arm: Convert Neon 3-reg-diff VABAL, VABDL to decodetree
53025bc target/arm: Convert Neon 3-reg-diff narrowing ops to decodetree
bc32157 target/arm: Convert Neon 3-reg-diff prewidening ops to decodetree
f6dc16f target/arm: Fix missing temp frees in do_vshll_2sh

=== OUTPUT BEGIN ===
1/7 Checking commit f6dc16f463ee (target/arm: Fix missing temp frees in 
do_vshll_2sh)
2/7 Checking commit bc3215754d8f (target/arm: Convert Neon 3-reg-diff 
prewidening ops to decodetree)
3/7 Checking commit 53025bc0a61e (target/arm: Convert Neon 3-reg-diff narrowing 
ops to decodetree)
4/7 Checking commit 42bfcfcc08ac (target/arm: Convert Neon 3-reg-diff VABAL, 
VABDL to decodetree)
5/7 Checking commit df05eae86282 (target/arm: Convert Neon 3-reg-diff long 
multiplies)
ERROR: space required after that ',' (ctx:VxV)
#93: FILE: target/arm/translate-neon.inc.c:2203:
+#define DO_VMLAL(INSN,MULL,ACC)                                         \
                      ^

ERROR: space required after that ',' (ctx:VxV)
#93: FILE: target/arm/translate-neon.inc.c:2203:
+#define DO_VMLAL(INSN,MULL,ACC)                                         \
                           ^

ERROR: space required after that ',' (ctx:VxV)
#111: FILE: target/arm/translate-neon.inc.c:2221:
+DO_VMLAL(VMLAL_S,mull_s,add)
                 ^

ERROR: space required after that ',' (ctx:VxV)
#111: FILE: target/arm/translate-neon.inc.c:2221:
+DO_VMLAL(VMLAL_S,mull_s,add)
                        ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: target/arm/translate-neon.inc.c:2222:
+DO_VMLAL(VMLAL_U,mull_u,add)
                 ^

ERROR: space required after that ',' (ctx:VxV)
#112: FILE: target/arm/translate-neon.inc.c:2222:
+DO_VMLAL(VMLAL_U,mull_u,add)
                        ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: target/arm/translate-neon.inc.c:2223:
+DO_VMLAL(VMLSL_S,mull_s,sub)
                 ^

ERROR: space required after that ',' (ctx:VxV)
#113: FILE: target/arm/translate-neon.inc.c:2223:
+DO_VMLAL(VMLSL_S,mull_s,sub)
                        ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: target/arm/translate-neon.inc.c:2224:
+DO_VMLAL(VMLSL_U,mull_u,sub)
                 ^

ERROR: space required after that ',' (ctx:VxV)
#114: FILE: target/arm/translate-neon.inc.c:2224:
+DO_VMLAL(VMLSL_U,mull_u,sub)
                        ^

total: 10 errors, 0 warnings, 138 lines checked

Patch 5/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/7 Checking commit 08c503092761 (target/arm: Convert Neon 3-reg-diff 
saturating doubling multiplies)
7/7 Checking commit fb9cd52b2791 (target/arm: Convert Neon 3-reg-diff 
polynomial VMULL)
WARNING: line over 80 characters
#157: FILE: target/arm/translate.c:5230:
+                /* Three registers of different lengths: handled by decodetree 
*/

total: 0 errors, 1 warnings, 131 lines checked

Patch 7/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200609160209.29960-1-peter.maydell@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20200609160209.29960-1-peter.maydell@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com