Re: [PATCH v2 0/5] TPM-TIS bios-tables-test

[no-reply]

Patchew URL: 
20200609125409.24179-1-eric.auger@redhat.com/">https://patchew.org/QEMU/20200609125409.24179-1-eric.auger@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200609125409.24179-1-eric.auger@redhat.com
Subject: [PATCH v2 0/5] TPM-TIS bios-tables-test
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200609125409.24179-1-eric.auger@redhat.com -> 
patchew/20200609125409.24179-1-eric.auger@redhat.com
Switched to a new branch 'test'
e6b236c bios-tables-test: Generate reference tables for Q35/TPM-TIS
7a4b9f2 bios-tables-test: Add Q35/TPM-TIS test
7fe76aa tests: tpm-emu: Remove assert on TPM2_ST_NO_SESSIONS
7a030be tests/acpi: Add void tables for Q35/TPM-TIS bios-tables-test
7610fad test/tpm-emu: include sockets and channel headers in tpm-emu header

=== OUTPUT BEGIN ===
1/5 Checking commit 7610fad0d9f9 (test/tpm-emu: include sockets and channel 
headers in tpm-emu header)
2/5 Checking commit 7a030be08a78 (tests/acpi: Add void tables for Q35/TPM-TIS 
bios-tables-test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and 
tests/qtest/bios-tables-test-allowed-diff.h found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and 
tests/qtest/bios-tables-test-allowed-diff.h found

total: 2 errors, 1 warnings, 3 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 7fe76aaf8d68 (tests: tpm-emu: Remove assert on 
TPM2_ST_NO_SESSIONS)
4/5 Checking commit 7a4b9f22ddbd (bios-tables-test: Add Q35/TPM-TIS test)
5/5 Checking commit e6b236c48806 (bios-tables-test: Generate reference tables 
for Q35/TPM-TIS)
ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and 
tests/qtest/bios-tables-test-allowed-diff.h found

ERROR: Do not add expected files together with tests, follow instructions in 
tests/qtest/bios-tables-test.c: both tests/data/acpi/q35/TPM2.tis and 
tests/qtest/bios-tables-test-allowed-diff.h found

total: 2 errors, 0 warnings, 1 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200609125409.24179-1-eric.auger@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200609125409.24179-1-eric.auger@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com