[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instea
From: |
Alistair Francis |
Subject: |
Re: [PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf |
Date: |
Tue, 26 May 2020 09:42:56 -0700 |
On Mon, May 25, 2020 at 11:25 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Replace some debug printf() calls by qemu_log_mask(LOG_UNIMP),
> and add a new one in cirrus_linear_bitblt_read().
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/display/cirrus_vga.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index 33ccdde000..f9f837b850 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -35,6 +35,7 @@
> #include "qemu/osdep.h"
> #include "qemu/module.h"
> #include "qemu/units.h"
> +#include "qemu/log.h"
> #include "sysemu/reset.h"
> #include "qapi/error.h"
> #include "trace.h"
> @@ -905,9 +906,8 @@ static int cirrus_bitblt_cputovideo(CirrusVGAState * s)
> static int cirrus_bitblt_videotocpu(CirrusVGAState * s)
> {
> /* XXX */
> -#ifdef DEBUG_BITBLT
> - printf("cirrus: bitblt (video to cpu) is not implemented yet\n");
> -#endif
> + qemu_log_mask(LOG_UNIMP,
> + "cirrus: bitblt (video to cpu) is not implemented\n");
> return 0;
> }
>
> @@ -989,9 +989,8 @@ static void cirrus_bitblt_start(CirrusVGAState * s)
> cirrus_blt_mode & (CIRRUS_BLTMODE_MEMSYSSRC |
> CIRRUS_BLTMODE_MEMSYSDEST))
> == (CIRRUS_BLTMODE_MEMSYSSRC | CIRRUS_BLTMODE_MEMSYSDEST)) {
> -#ifdef DEBUG_BITBLT
> - printf("cirrus: bitblt - memory-to-memory copy is requested\n");
> -#endif
> + qemu_log_mask(LOG_UNIMP,
> + "cirrus: bitblt - memory-to-memory copy requested\n");
> goto bitblt_ignore;
> }
>
> @@ -2412,6 +2411,9 @@ static uint64_t cirrus_linear_bitblt_read(void *opaque,
>
> /* XXX handle bitblt */
> (void)s;
> + qemu_log_mask(LOG_UNIMP,
> + "cirrus: linear bitblt is not implemented\n");
> +
> return 0xff;
> }
>
> --
> 2.21.3
>
>
- [PATCH 00/14] hw/display: Omnibus cleanups, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 01/14] hw/display/edid: Add missing 'qdev-properties.h' header, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 02/14] hw/display/cg3: Convert debug printf()s to trace events, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 03/14] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf, Philippe Mathieu-Daudé, 2020/05/26
- Re: [PATCH 04/14] hw/display/cirrus_vga: Use qemu_log_mask(UNIMP) instead of debug printf,
Alistair Francis <=
- [PATCH 06/14] hw/display/cirrus_vga: Convert debug printf() to trace event, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 07/14] hw/display/dpcd: Fix memory region size, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 05/14] hw/display/cirrus_vga: Use qemu_log_mask(ERROR) instead of debug printf, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 08/14] hw/display/dpcd: Convert debug printf()s to trace events, Philippe Mathieu-Daudé, 2020/05/26
- [PATCH 09/14] hw/display/xlnx_dp: Replace disabled DPRINTF() by error_report(), Philippe Mathieu-Daudé, 2020/05/26