[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/11] rules.mak: Add base-arch() rule
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 09/11] rules.mak: Add base-arch() rule |
Date: |
Fri, 22 May 2020 17:15:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 5/22/20 6:24 AM, Richard Henderson wrote:
> On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote:
>> + $(if $(findstring risc,$1),risc,\
>
> Eh? riscv{32,64} vs openrisc.
Nice catch, because with this patch openrisc builds with a riscv
config-devices.h =)
>
>> + $(if $(findstring x86,$1),i386,\
>
> Do we really not need an exact match for x86_64?
OK.
>
>> + $(if $(findstring aarch64,$1),arm,$1)))))))
>
> Exact match?
OK.
>
>
> r~
>
- [PATCH v3 01/11] MAINTAINERS: Fix KVM path expansion glob, (continued)
- [PATCH v3 01/11] MAINTAINERS: Fix KVM path expansion glob, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 02/11] MAINTAINERS: Add an 'overall' entry for accelerators, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 03/11] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 04/11] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 05/11] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 06/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 07/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 08/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 09/11] rules.mak: Add base-arch() rule, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/21
- [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it, Philippe Mathieu-Daudé, 2020/05/21
- Re: [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default, no-reply, 2020/05/21