[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig |
Date: |
Thu, 21 May 2020 19:33:10 +0200 |
On Fri, May 15, 2020 at 7:08 PM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> Allow use of target-specific Kconfig file.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b4c0830b26..5fce168fcb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -423,11 +423,13 @@ MINIKCONF_INPUTS = $(SRC_PATH)/Kconfig.host \
> $(SRC_PATH)/accel/Kconfig \
> $(SRC_PATH)/hw/Kconfig
> MINIKCONF_DEPS = $(MINIKCONF_INPUTS) \
> - $(wildcard $(SRC_PATH)/hw/*/Kconfig)
> + $(wildcard $(SRC_PATH)/hw/*/Kconfig) \
> + $(wildcard $(SRC_PATH)/target/*/Kconfig)
> MINIKCONF = $(PYTHON) $(SRC_PATH)/scripts/minikconf.py
>
> $(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak
> $(MINIKCONF_DEPS) $(BUILD_DIR)/config-host.mak
> $(call quiet-command, $(MINIKCONF) $(MINIKCONF_ARGS) \
> + $(wildcard $(SRC_PATH)/target/$(firstword $(subst -,
> ,$@))/Kconfig) \
This is incorrect, $@ is a $TARGET_ARCH (example aarch64) and we want
to include $TARGET_BASE_ARCH (example arm).
> > $@.tmp, "GEN", "$@.tmp")
> $(call quiet-command, if test -f $@; then \
> if cmp -s $@.old $@; then \
> --
> 2.21.3
>
- [PATCH v2 04/10] accel/tcg: Add stub for probe_access(), (continued)
- [PATCH v2 04/10] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 05/10] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 06/10] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 07/10] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 08/10] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 09/10] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/15
- [PATCH v2 10/10] hw/semihosting: Make the feature depend of TCG, and allow to disable it, Philippe Mathieu-Daudé, 2020/05/15
- Re: [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default, no-reply, 2020/05/15
- Re: [PATCH v2 00/10] accel: Allow targets to use Kconfig, disable semihosting by default, no-reply, 2020/05/15