|
From: | Richard Henderson |
Subject: | Re: [PATCH 09/10] target/arm: Convert VCVT fixed-point ops to decodetree |
Date: | Fri, 15 May 2020 19:27:09 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/15/20 7:20 AM, Peter Maydell wrote: > +# VCVT fixed<->float conversions > +# TODO: FP16 fixed<->float conversions are opc==0b1100 and 0b1101 > +# We use size=0 for fp32 and size=1 for fp16 to match the 3-same encodings. > +VCVT_SF_2sh 1111 001 0 1 . 1 shift:5 .... 1110 0 . . 1 .... \ > + @2reg_shift size=0 Maybe use %neon_rshift_i5 so you can drop > + /* > + * The decode doesn't include the must-be-1 top bit of imm6 in a->shift, > + * hence this 32-shift where the ARM ARM has 64-imm6. > + */ > + shiftv = tcg_const_i32(32 - a->shift); this. Otherwise, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |