Re: [PATCH 2/4] hw/arm/nrf51_soc: Mark some peripherals as unimplemented

[Philippe Mathieu-Daudé]

+Ioannis

On 5/4/20 7:13 PM, Richard Henderson wrote:
> On 5/4/20 12:28 AM, Philippe Mathieu-Daudé wrote:
> > Map some peripherals used by Zephyr Project:
> >
> > https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/dts/arm/nordic/nrf51822.dtsi
> >
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   include/hw/arm/nrf51.h |  4 ++++
> >   hw/arm/nrf51_soc.c     | 11 +++++++++++
> >   2 files changed, 15 insertions(+)
>
> There's a fair few more devices listed in the manual, and not all of the ones
> that you add here are referenced in the dts files.  So what criteria are you
> using to choose?

Fair question :)

The board DTS [1] ends pulling in nrf51822.dtsi.

To be able to use the soft PWM declared in [2] and implemented in [3] 
(with timers and gpios), I added this commit on top:

https://gitlab.com/philmd/zephyr/-/commit/90b081cf79

But I won't send a pullrequest to Zephyr until the PPI is properly 
implemented in QEMU.

[1] 
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/boards/arm/qemu_cortex_m0/qemu_cortex_m0.dts
[2] 
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/dts/arm/nordic/nrf5_common.dtsi
[3] 
https://github.com/zephyrproject-rtos/zephyr/blob/zephyr-v2.2.0/drivers/pwm/pwm_nrf5_sw.c

> Perhaps it would be easier to add them all?

Or better document this commit ;)

> r~