Re: [PATCH 23/36] target/arm: Convert Neon 64-bit element 3-reg-same insns

[Richard Henderson]

On 5/1/20 8:57 AM, Peter Maydell wrote:
> On Fri, 1 May 2020 at 16:50, Richard Henderson
> <address@hidden> wrote:
>> The original intention of the hook is to expand some inline tcg ops.  That it
>> can be used to call a helper is a happy accident.  For a helper that needs 
>> env,
>> ideally we would use tcg_gen_gvec_ptr and handle the vector with one call.
> 
> The inconsistency where half the helpers nede to be passed cpu_env
> and the other half don't is really irritating for writing code
> that calls them. Lots of ought-to-be-common code ends up needing
> two versions :-(

Yep.  Lots of room for additional cleanup here.


r~