Re: [PATCH v2 0/5] target/arm: Restrict TCG cpus to TCG accel

[Peter Maydell]

On Thu, 23 Apr 2020 at 08:34, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> These are the uncontroversial patches from "Support disabling
> TCG on ARM (part 2)"
> https://www.mail-archive.com/address@hidden/msg689168.html
>
> The other patches are blocked by the "accel: Allow targets to
> use Kconfig" series:
> https://www.mail-archive.com/address@hidden/msg689024.html
>
> All patches reviewed.
>
> Since v1:
> - Dropped 'Make set_feature() available for other files' patch
>   which fails to build with KVM only, see:
> https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg03843.html
>
> Many thanks to Richard Henderson for his patience!
>
> Regards,
>
> Phil.
>
> Philippe Mathieu-Daudé (4):
>   target/arm: Restric the Address Translate write operation to TCG accel
>   target/arm/cpu: Use ARRAY_SIZE() to iterate over ARMCPUInfo[]
>   target/arm/cpu: Update coding style to make checkpatch.pl happy
>   target/arm: Restrict TCG cpus to TCG accel
>
> Thomas Huth (1):
>   target/arm: Make cpu_register() available for other files


Patch 5 doesn't compile, because it moves code out from
cpu.c to cpu_tcg.c, where it no longer has access to the
file-local set_feature() function:

  CC      arm-softmmu/target/arm/cpu_tcg.o
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:47:5:
error: implicit declaration of function 'set_feature' is invalid in
C99
      [-Werror,-Wimplicit-function-declaration]
    set_feature(&cpu->env, ARM_FEATURE_V5);
    ^
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:47:5:
note: did you mean 'arm_feature'?
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu.h:1940:19:
note: 'arm_feature' declared here
static inline int arm_feature(CPUARMState *env, int feature)
                  ^
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:47:5:
error: this function declaration is not a prototype
[-Werror,-Wstrict-prototypes]
    set_feature(&cpu->env, ARM_FEATURE_V5);
    ^
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:74:5:
error: implicit declaration of function 'set_feature' is invalid in
C99
      [-Werror,-Wimplicit-function-declaration]
    set_feature(&cpu->env, ARM_FEATURE_V5);
    ^
/home/petmay01/linaro/qemu-from-laptop/qemu/target/arm/cpu_tcg.c:87:5:
error: implicit declaration of function 'set_feature' is invalid in
C99
      [-Werror,-Wimplicit-function-declaration]
    set_feature(&cpu->env, ARM_FEATURE_V5);
    ^
[etc]

I've applied patches 1-4 to target-arm.next.


thanks
-- PMM