[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/16] target/arm: Update contiguous first-fault and no-fault
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 11/16] target/arm: Update contiguous first-fault and no-fault loads |
|
Date: |
Fri, 17 Apr 2020 20:36:09 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 4/16/20 7:15 AM, Peter Maydell wrote:
>> + * While we do not have access to the memory attributes from the PTE
>> + * to tell Device memory from Normal memory, we can validly assume that
>> + * non-RAM has been mapped as Device memory. Thus we indicate fault
>> + * on all MMIO.
>
> I don't think you can assume this; for instance a QEMU 'romd'
> device might reasonably be mapped as Normal memory but currently
> be in "send all accesses to my read/write functions" mode.
If that is so, then TLB_MMIO will be set in the tlb_entry comparator. See
accel/tcg/cputlb.c:882.
r~