Re: [Qemu devel PATCH v4 1/3] hw/net: Add Smartfusion2 emac block

[Philippe Mathieu-Daudé]

On Tue, Apr 14, 2020 at 3:05 PM sundeep subbaraya
<address@hidden> wrote:
>
> Hi Philippe,
>
> On Mon, Apr 13, 2020 at 2:16 AM Philippe Mathieu-Daudé <address@hidden> wrote:
> >
> > Hi Sundeep,
> >
> > On 4/10/20 4:45 PM, address@hidden wrote:
> > > From: Subbaraya Sundeep <address@hidden>
> > >
> > > Modelled Ethernet MAC of Smartfusion2 SoC.
> > > Micrel KSZ8051 PHY is present on Emcraft's
> > > SOM kit hence same PHY is emulated.
> > >
> > > Signed-off-by: Subbaraya Sundeep <address@hidden>
> > > ---
[...]
> > > +static const VMStateDescription vmstate_msf2_emac = {
> > > +    .name = TYPE_MSS_EMAC,
> > > +    .version_id = 1,
> > > +    .minimum_version_id = 1,
> > > +    .fields = (VMStateField[]) {
> > > +        VMSTATE_UINT32(rx_desc, MSF2EmacState),
> > > +        VMSTATE_UINT16_ARRAY(phy_regs, MSF2EmacState, PHY_MAX_REGS),
> >
> > Later we'll move the PHY registers out of the EMAC. Not now...
> >
> Cool but how? Like SSI and I2C, mdio bus?

Don't worry about it now, it was more as a comment to myself. I have
some series doing it, I'll cc you when it is ready.

>
> > > +        VMSTATE_UINT32_ARRAY(regs, MSF2EmacState, R_MAX),
> > > +        VMSTATE_END_OF_LIST()
> > > +    }
> > > +};
[...]