[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.0] hw/gpio/aspeed_gpio.c: Don't directly include assert
|
From: |
Andrew Jeffery |
|
Subject: |
Re: [PATCH for-5.0] hw/gpio/aspeed_gpio.c: Don't directly include assert.h |
|
Date: |
Sun, 05 Apr 2020 16:31:08 +0930 |
|
User-agent: |
Cyrus-JMAP/3.1.7-1082-g13d7805-fmstable-20200403v1 |
On Fri, 3 Apr 2020, at 23:17, Peter Maydell wrote:
> Remove a direct include of assert.h -- this is already
> provided by qemu/osdep.h, and it breaks our rule that the
> first include must always be osdep.h.
>
> In particular we must get the assert() macro via osdep.h
> to avoid compile failures on mingw (see the comment in
> osdep.h where we redefine assert() for that platform).
>
> Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Andrew Jeffery <address@hidden>