[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration/throttle: Add throttle-trig-thres migration parame
From: |
zhukeqian |
Subject: |
Re: [PATCH] migration/throttle: Add throttle-trig-thres migration parameter |
Date: |
Fri, 13 Mar 2020 11:25:30 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
Hi Dr. David,
On 2020/3/13 2:07, Dr. David Alan Gilbert wrote:
> * Keqian Zhu (address@hidden) wrote:
>> Currently, if the bytes_dirty_period is more than the 50% of
>> bytes_xfer_period, we start or increase throttling.
>>
>> If we make this percentage higher, then we can tolerate higher
>> dirty rate during migration, which means less impact on guest.
>> The side effect of higher percentage is longer migration time.
>> We can make this parameter configurable to switch between mig-
>> ration time first or guest performance first.
>>
>> The default value is 50 and valid range is 1 to 100.
>>
>> Signed-off-by: Keqian Zhu <address@hidden>
>
> Apologies for the delay.
It is not late, no worries ;).
> This looks fine now; so
>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>
> and I'll queue it.
Thanks.
> I think we could do with a better description than the current one if we
> can find it:
>
> The ratio of bytes_dirty_period and bytes_xfer_period
> to trigger throttling. It is expressed as percentage.
>
> assumes people understand what those bytes*period mean.
>
> Still, until we do:
>
> Queued for migration
>
[...]
>> --
>> 2.19.1
>>
> --
> Dr. David Alan Gilbert / address@hidden / Manchester, UK
>
>
> .
>
Thanks,
Keqian