Re: [PATCH 0/2] aspeed/smc: fix data corruption on witherspoon machines

[Cédric Le Goater]

On 2/6/20 12:26 PM, Cédric Le Goater wrote:
> Hello,
> 
> We have been seeing a squashfs corruption on the witherspoon-bmc
> machine for quite some time. It boots but quickly after boot
> corruption errors start to fill the console. This machine has two BMC
> chips with UBIfs on them. The romulus-bmc machine has a similar
> problem when both PNOR are enabled.
> 
> After some investigation, it appeared that the SPI transfers on the
> two chips were getting mixed and after more investigation, the User
> mode select/unselect scheme of the Aspeed SMC model proved to be
> broken. It's been there since the right beginning of the model. Here
> is a fix.
> 
> Kudos to Andrew J. for the time he spent on this and Andrew G. for his
> patience.
> 
> I pushed the code on my github branch aspeed-5.0 for more testing.
> 
> Thanks,
> 
> C.
> 
> Cédric Le Goater (2):
>   aspeed/smc: Add some tracing
>   aspeed/smc: Fix User mode select/unselect scheme
> 
>  Makefile.objs       |  1 +
>  hw/ssi/aspeed_smc.c | 56 ++++++++++++++++++++++++++++++++-------------
>  hw/ssi/trace-events | 10 ++++++++
>  3 files changed, 51 insertions(+), 16 deletions(-)
>  create mode 100644 hw/ssi/trace-events

Hello Peter, 

If you have some time to take a look, it would be nice to get this 
fix in QEMU 5.0. 

Thanks,

C.