[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h"
From: |
Laurent Vivier |
Subject: |
[PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h" |
Date: |
Mon, 9 Mar 2020 16:08:26 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Both ich9.c and piix4.c use methods/definitions declared in the
NVDIMM device header. Include it.
This fixes (when modifying unrelated headers):
hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/ich9.c:508:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
hw/acpi/piix4.c:403:46: error: use of undeclared identifier 'TYPE_NVDIMM'
if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) {
^
hw/acpi/piix4.c:404:13: error: implicit declaration of function
'nvdimm_acpi_plug_cb' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
nvdimm_acpi_plug_cb(hotplug_dev, dev);
^
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
hw/acpi/ich9.c | 1 +
hw/acpi/piix4.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index fdd0a6c79e11..4e74284b65b7 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -39,6 +39,7 @@
#include "hw/i386/ich9.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
//#define DEBUG
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 6d621c31e751..b84dbba2c3e8 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -38,6 +38,7 @@
#include "hw/acpi/cpu.h"
#include "hw/hotplug.h"
#include "hw/mem/pc-dimm.h"
+#include "hw/mem/nvdimm.h"
#include "hw/acpi/memory_hotplug.h"
#include "hw/acpi/acpi_dev_interface.h"
#include "hw/xen/xen.h"
--
2.24.1
- [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, (continued)
- [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, Laurent Vivier, 2020/03/09
- [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header, Laurent Vivier, 2020/03/09
- [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Laurent Vivier, 2020/03/09
- [PULL 25/33] hw/i386/pc: Clean up includes, Laurent Vivier, 2020/03/09
- [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector(), Laurent Vivier, 2020/03/09
- [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h", Laurent Vivier, 2020/03/09
- [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const, Laurent Vivier, 2020/03/09
- [PULL 16/33] hw/hppa/machine: Include "net/net.h", Laurent Vivier, 2020/03/09
- [PULL 20/33] hw/i2c/smbus_ich9: Include "qemu/range.h", Laurent Vivier, 2020/03/09
- [PULL 24/33] hw/pci-host/q35: Remove unused includes, Laurent Vivier, 2020/03/09
- [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h",
Laurent Vivier <=
- [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Laurent Vivier, 2020/03/09
- [PULL 21/33] hw/pci-host/piix: Include "qemu/range.h", Laurent Vivier, 2020/03/09
- [PULL 23/33] hw/i386: Include "hw/mem/nvdimm.h", Laurent Vivier, 2020/03/09
- [PULL 27/33] block/stream: Remove redundant statement in stream_run(), Laurent Vivier, 2020/03/09
- [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), Laurent Vivier, 2020/03/09
- [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), Laurent Vivier, 2020/03/09
- [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Laurent Vivier, 2020/03/09
- [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), Laurent Vivier, 2020/03/09
- [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), Laurent Vivier, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, no-reply, 2020/03/09