|
From: | Richard Henderson |
Subject: | Re: [PATCH v2 5/6] hw/arm/virt: kvm: Check the chosen gic version is supported by the host |
Date: | Sun, 1 Mar 2020 09:56:05 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/1/20 2:40 AM, Eric Auger wrote: > + /* Check chosen version is effectively supported by the host */ > + if (vms->gic_version == VIRT_GIC_VERSION_2 && > + !(probe_bitmap & KVM_ARM_VGIC_V2)) { > + error_report("host does not support in-kernel GICv2 > emulation"); > + exit(1); > + } else if (vms->gic_version == VIRT_GIC_VERSION_3 && > + !(probe_bitmap & KVM_ARM_VGIC_V3)) { > + error_report("host does not support in-kernel GICv3 > emulation"); > + exit(1); > + } Indentation is wrong here. > + case VIRT_GIC_VERSION_HOST: > + error_report("gic-version=host requires KVM"); > + exit(1); > + default: /* explicit V2/V3 are left untouched */ > + break; > } I'd prefer to just list V2 and V3 here explicitly, instead of the default. It'll be nicer with gic_version changed to an enum. With those changes, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |