[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v24 04/10] ACPI: Build related register address fields via ha
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob |
Date: |
Tue, 25 Feb 2020 14:57:12 +0100 |
On Tue, 25 Feb 2020 09:48:04 +0100
Igor Mammedov <address@hidden> wrote:
> On Mon, 17 Feb 2020 21:12:42 +0800
> Dongjiu Geng <address@hidden> wrote:
>
> > This patch builds error_block_address and read_ack_register fields
> > in hardware errors table , the error_block_address points to Generic
> > Error Status Block(GESB) via bios_linker. The max size for one GESB
> > is 1kb in bytes, For more detailed information, please refer to
>
> s/1kb in bytes/1Kb/
>
> > document: docs/specs/acpi_hest_ghes.rst
> >
> > Now we only support one Error source, if necessary, we can extend to
> > support more.
> >
> > Suggested-by: Laszlo Ersek <address@hidden>
> > Signed-off-by: Dongjiu Geng <address@hidden>
> > Signed-off-by: Xiang Zheng <address@hidden>
> > Reviewed-by: Jonathan Cameron <address@hidden>
> > ---
>
On the second glance,
[...]
> > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
> > index bd5f771..6819fcf 100644
> > --- a/hw/arm/virt-acpi-build.c
> > +++ b/hw/arm/virt-acpi-build.c
> > @@ -48,6 +48,7 @@
> > #include "sysemu/reset.h"
> > #include "kvm_arm.h"
> > #include "migration/vmstate.h"
> > +#include "hw/acpi/ghes.h"
> >
> > #define ARM_SPI_BASE 32
> >
> > @@ -830,6 +831,11 @@ void virt_acpi_build(VirtMachineState *vms,
> > AcpiBuildTables *tables)
> > acpi_add_table(table_offsets, tables_blob);
> > build_spcr(tables_blob, tables->linker, vms);
> >
> > + if (vms->ras) {
> > + acpi_add_table(table_offsets, tables_blob);
that doesn't look right, it's for tables that should be referenced
from XSDT
> > + build_ghes_error_table(tables->hardware_errors, tables->linker);
but this table isn't pointed by XSDT directly.
I suggest to move acpi_add_table() to the patch that adds acpi_build_hest()
> > + }
> > +
> > if (ms->numa_state->num_nodes > 0) {
> > acpi_add_table(table_offsets, tables_blob);
> > build_srat(tables_blob, tables->linker, vms);
[...]
- Re: [PATCH v24 02/10] hw/arm/virt: Introduce a RAS machine option, (continued)
[PATCH v24 07/10] KVM: Move hwpoison page related functions into kvm-all.c, Dongjiu Geng, 2020/02/17
[PATCH v24 01/10] acpi: nvdimm: change NVDIMM_UUID_LE to a common macro, Dongjiu Geng, 2020/02/17
[PATCH v24 05/10] ACPI: Build Hardware Error Source Table, Dongjiu Geng, 2020/02/17
[PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob, Dongjiu Geng, 2020/02/17
[PATCH v24 03/10] docs: APEI GHES generation and CPER record description, Dongjiu Geng, 2020/02/17
[PATCH v24 08/10] ACPI: Record Generic Error Status Block(GESB) table, Dongjiu Geng, 2020/02/17
[PATCH v24 06/10] ACPI: Record the Generic Error Status Block address, Dongjiu Geng, 2020/02/17
[PATCH v24 10/10] MAINTAINERS: Add ACPI/HEST/GHES entries, Dongjiu Geng, 2020/02/17
[PATCH v24 09/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM, Dongjiu Geng, 2020/02/17
Re: [PATCH v24 00/10] Add ARMv8 RAS virtualization support in QEMU, Peter Maydell, 2020/02/21